Update Bookmark manager for no longer tracking per database #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on: neo4j-drivers/testkit#534 |
bigmontz
force-pushed
the
5.x-update-to-bookmark-manager
branch
2 times, most recently
from
287bb9b to
b5ebe23
Compare
bigmontz
commented
Nov 23, 2022
Changes in the BookmarkManagerConfig: * `initialBookmarks` type changed from `Map<string,Iterable<string>>` to `Iterable<string>` * `bookmarksSupplier` type changed from `(db?: string) => Promise<Iterable<string>>` to `() => Promise<Iterable<string>>` * `bookmarksConsumer` type changed from `(db: string, bookmarks: Iterable<string>) => Promise<void>` to `(bookmarks: Iterable<string>) => Promise<void>` Changes in the BookmarkManager: * `getAllBookmarks` and `forget` were removed * `updateBookmarks` signature changed to `updateBookmarks (previousBookmarks: Iterable<string>, newBookmarks: Iterable<string>): Promise<void>` * `getBookmarks` signature changed to `getBookmarks (): Promise<Iterable<string>>`⚠️ This is a experimental feature.
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
Co-authored-by: grant lodge <6323995+thelonelyvulpes@users.noreply.github.com>
bigmontz
force-pushed
the
5.x-update-to-bookmark-manager
branch
from
f9aa8f2 to
528210f
Compare
bigmontz
added a commit
to bigmontz/neo4j-javascript-driver
that referenced
this pull request
Nov 25, 2022
Changes in the BookmarkManagerConfig: * `initialBookmarks` type changed from `Map<string,Iterable<string>>` to `Iterable<string>` * `bookmarksSupplier` type changed from `(db?: string) => Promise<Iterable<string>>` to `() => Promise<Iterable<string>>` * `bookmarksConsumer` type changed from `(db: string, bookmarks: Iterable<string>) => Promise<void>` to `(bookmarks: Iterable<string>) => Promise<void>` Changes in the BookmarkManager: * `getAllBookmarks` and `forget` were removed * `updateBookmarks` signature changed to `updateBookmarks (previousBookmarks: Iterable<string>, newBookmarks: Iterable<string>): Promise<void>` * `getBookmarks` signature changed to `getBookmarks (): Promise<Iterable<string>>`⚠️ This is a experimental feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the BookmarkManagerConfig:
initialBookmarkstype changed fromMap<string,Iterable<string>>toIterable<string>bookmarksSuppliertype changed from(db?: string) => Promise<Iterable<string>>to() => Promise<Iterable<string>>bookmarksConsumertype changed from(db: string, bookmarks: Iterable<string>) => Promise<void>to(bookmarks: Iterable<string>) => Promise<void>Changes in the BookmarkManager:
getAllBookmarksandforgetwere removedupdateBookmarkssignature changed toupdateBookmarks (previousBookmarks: Iterable<string>, newBookmarks: Iterable<string>): Promise<void>getBookmarkssignature changed togetBookmarks (): Promise<Iterable<string>>